Repository navigation
fix(files): honor File Viewer header setting on phones - #809
Conversation
|
Thank you, @DodgyBadger. With this PR the File Viewer header button follows its setting on phones: it is off by default, and once someone turns it on it shows up with a 44px touch target. That matches what we agreed on #759, and the real-browser test at 390px is what I was hoping for. I ran that test against master's Three small things, none of them blocking:
These are small enough that I will apply them on top when I merge, once the unit test job in CI finishes. If you would rather push them yourself first, that works too. Thanks again, and good luck with the lazy-loading half. |
…again (#809) Until #809 a display:none rule in mobile.css and its KNOWN_PHONE_HIDDEN entry kept the File Viewer button off phones, and the gate checked both. With that rule gone, the handheld default in getDefaultSettings() and the html.mobile-init startup rule are the whole lock, and only the browser test saw them, which npm test does not run. The policy test now loads the real getDefaultSettings() on a handheld and on a desktop, checks that every reader of the setting goes through the device default, and that mobile.css keeps the startup hide. Docs: architecture-invariants, src/web/CLAUDE.md and the wiki say the button is off on a phone until it is switched on there, and that a window narrower than 600px on a device that is not a handheld now shows it. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Merged, and it shipped today in Codeman 1.51.0, with you in the release's Thanks. Thank you, @DodgyBadger. The three items from the review went in at merge time. The main one: with the phone rule gone from One thing I found on the way, and kept: a device that is not a handheld takes the desktop default at any width, so a desktop window or an iPad split view narrower than 600px now shows the button, where the old rule hid it. It fits and nothing overflows. The release notes list it as a behaviour change. #759 stays open for the second half, loading directories on demand. |
Enabling File Viewer in header settings now shows its button on phones. The phone default remains off, with startup hiding preserved until settings load.
The button retains a 44px touch target while matching neighbouring icon spacing. Browser coverage verifies settings persistence, opening and closing the panel, and essential controls at 390px.
Addresses the mobile-access portion of #759. Lazy loading remains separate.
Validation
spreadsheet-preview-worker.test.ts: stress test exceeds its 60-second timeout.remote-pane-command-shell.test.ts: login-shell environment causes the fallback fixture to fail.